Test for issue #520 #527
Merged
Test for issue #520 #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected void setUp() throws Exception { | ||
| String[] commands = {"cmd", "/c", "start", "iexplore.exe","-nohome", "\"http://www.srh.noaa.gov/jax\""}; | ||
| Runtime.getRuntime().exec(commands); | ||
| Thread.sleep(30000); |
There was a problem hiding this comment.
Can we do something a little smarter than a 30 second wait and a browse to a specific website? Maybe launch it via Win32 API and ShellExecute?
There was a problem hiding this comment.
I launched IE via Runtime.getRuntime().exec() because it's not the default browser on any of my systems - ShellExecute would open Chrome or Firefox on them.
If this will run only on boxes with IE as the default then I can adapt it accordingly.
As for the 30 second delay, that was the simplest way to give the page a chance to load. I'll change the target URL to "about:blank" - that should load instantly.
|
Ok this is good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Daniel D's request in the Google Group thread, here's a test for issue #520