Allow calling COM methods/getters requirering hybrid calling (METHOD+PROPERTYGET convention) #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
force-pushed
the
com_hybrid_calling_convention
branch
from
bdbf362
to
c5b9ca7
Compare
| @@ -35,6 +35,7 @@ Features | |||
| * [#569](https://github.com/java-native-access/jna/pull/569): Added `com.sun.jna.platform.win32.Winspool.PRINTER_INFO_2` support. Added GetPrinter and ClosePrinter functions in `com.sun.jna.platform.win32.Winspool` - [@IvanRF](https://github.com/IvanRF). | |||
| * [#583](https://github.com/java-native-access/jna/pull/583): Added printer attributes and status - [@IvanRF](https://github.com/IvanRF). | |||
| * [#589](https://github.com/java-native-access/jna/pull/589): Use MethodResultContext in direct mapping (as done in interface mapping) - [@marco2357](https://github.com/marco2357). | |||
| * [#595](https://github.com/java-native-access/jna/pull/595): Allow calling COM methods/getters requirering hybrid calling (METHOD+PROPERTYGET) [@matthiasblaesing](https://github.com/matthiasblaesing). | |||
There was a problem hiding this comment.
Thanks - was corrected.
matthiasblaesing
force-pushed
the
com_hybrid_calling_convention
branch
from
c5b9ca7
to
5127195
Compare
…PROPERTYGET convention) It was found, that calling InchesToPoints method from word type library failed. Research lead to https://www.delphitools.info/2013/04/30/gaining-visual-basic-ole-super-powers/ https://msdn.microsoft.com/en-us/library/windows/desktop/ms221486(v=vs.85).aspx Summary: there are methods in the word typelibrary that require both PROPERTYGET _and_ METHOD to be set. With only one of these set the call fails. The article from delphitools argues, that automation compatible libraries need to be compatible with VisualBasic which does not distingish methods and property getters and will set both flags always. The MSDN article advises this behaviour: "[...] Some languages cannot distinguish between retrieving a property and calling a method. In this case, you should set the flags DISPATCH_PROPERTYGET and DISPATCH_METHOD. [...]" This further support the advised way from delphitools and was implemented.
matthiasblaesing
force-pushed
the
com_hybrid_calling_convention
branch
from
5127195
to
5ab9cd0
Compare
dblock
added a commit
that referenced
this pull request
Feb 16, 2016
…ention Allow calling COM methods/getters requirering hybrid calling (METHOD+PROPERTYGET convention)
|
Merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found, that calling InchesToPoints method from word type library
failed. Research lead to
https://www.delphitools.info/2013/04/30/gaining-visual-basic-ole-super-powers/
https://msdn.microsoft.com/en-us/library/windows/desktop/ms221486(v=vs.85).aspx
Summary: there are methods in the word typelibrary that require both
PROPERTYGET and METHOD to be set. With only one of these set the call
fails.
The article from delphitools argues, that automation compatible libraries
need to be compatible with VisualBasic which does not distingish methods
and property getters and will set both flags always.
The MSDN article advises this behaviour: "[...] Some languages cannot
distinguish between retrieving a property and calling a method. In this
case, you should set the flags DISPATCH_PROPERTYGET and DISPATCH_METHOD.
[...]"
This further support the advised way from delphitools and was implemented.