-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to support LPPRINTER_DEFAULTS #836
Conversation
JNA requires exposed fields to be public for access outside the JNA package.
Thank you - I have some comments:
|
I've tried to rebase a dozen times and can't seem to get GitHub to merge
all of my commits into a single entry. Oh well.
…On Tue, Aug 1, 2017 at 2:12 PM, Matthias Bläsing ***@***.***> wrote:
Thank you - I have some comments:
- please rename the class to PRINTER_DEFAULTS (
https://msdn.microsoft.com/de-de/library/windows/desktop/
dd162839(v=vs.85).aspx
<https://msdn.microsoft.com/de-de/library/windows/desktop/dd162839(v=vs.85).aspx>),
as that is the correct name and the class can't be currently used
- merge the changes into one change (git squash)
- add the fix at the end of Bugfixes section for 4.5 in
https://github.com/java-native-access/jna/blob/master/CHANGES.md
<https://github.com/java-native-access/jna/blob/master/CHANGES.md>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#836 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACN9szNeJ_x8X1zdK1fOhzIPdsnJW_YTks5sT3iHgaJpZM4OqG_m>
.
|
@ericzhill you don't need to rebase your changes, you should squash them. The difference: For command line instructions, please see here: If you use a gui client, you'd have to refer to its documentation. After squashing, you need to do a forced push, as you changed history. nitpick: OpenPrinter refers to PRINTER_DEFAULTS, so that needs to be adjusted too. |
This request should satisfy #834