Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to support LPPRINTER_DEFAULTS #836

Closed
wants to merge 10 commits into from
Closed

Modifications to support LPPRINTER_DEFAULTS #836

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2017

This request should satisfy #834

ericzhill and others added 2 commits July 31, 2017 08:49
JNA requires exposed fields to be public for access outside the JNA package.
@matthiasblaesing
Copy link
Member

Thank you - I have some comments:

@ghost ghost closed this Aug 1, 2017
@ghost
Copy link
Author

ghost commented Aug 1, 2017 via email

@matthiasblaesing
Copy link
Member

@ericzhill you don't need to rebase your changes, you should squash them.

The difference:
rebase => change the base for the changesets
squash => compact multiple changesets into one

For command line instructions, please see here:
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_squashing

If you use a gui client, you'd have to refer to its documentation. After squashing, you need to do a forced push, as you changed history.

nitpick: OpenPrinter refers to PRINTER_DEFAULTS, so that needs to be adjusted too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants