#136 Pass-Through JNI exceptions to caller in waitEvents #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is simple and sane; I have no objections to merging this. In regards to testing, I'm not sure where to begin. If we decide to test before merging, we'll likely need a volunteer to do this. If this requires offering a one-off build, I can help with that. |
tresf
reviewed
Nov 8, 2023
hiddenalpha
deleted the
issue-136-AddSomeErrorHandlingInNativeWaitEvents
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Compiles on my machine". But unluckily I do not have a setup available where I could test it meaningfully.
Therefore: TODO would be nice if somebody could test it.
Closes: #136