Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Squash commits from cross-compile pipeline + update actions and runners versions #154

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

pietrygamat
Copy link
Collaborator

A small improvement to cross-compilation pipeline. It now generates a branch with a single commit with all precompiled binaries, instead of one commit per architecture.

E.g. https://github.com/pietrygamat/jssc/commits/single-commit-natives-precompiled-natives.

@tresf
Copy link

tresf commented Nov 11, 2023

No objections.

A word on ubuntu-latest:

  • Note, when you do things like ubuntu-latest versus ubuntu-20.04, it means that when a dependency name changes, our CI will fail. This is fine with me, because latest prevents the action from bitrot and is arguably easier than trying to remember which LTS releases are still supported by GitHub.
  • Another caution... for larger projects... binaries created with ubuntu-latest may suffer regressions. This is best explained here.
  • Our binaries are quite simple and the ones we distribute are built using docker, so this is not as much of a concern, but wanted to mention this.

In regards to merging, I will ask you to do so at your leisure.

@pietrygamat pietrygamat merged commit 0cd6aef into java-native:master Nov 11, 2023
13 checks passed
@pietrygamat pietrygamat deleted the single-commit-natives branch November 11, 2023 11:19
@pietrygamat pietrygamat added this to the 2.9.6 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants