-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report some read errors back to java code. #155
Report some read errors back to java code. #155
Conversation
30ddacc
to
03168ad
Compare
03168ad
to
f6976c1
Compare
Relates to java-native#126 Taken from 19610bc.
f6976c1
to
772f9be
Compare
a6b8de8
to
e0f22a5
Compare
e0f22a5
to
661987e
Compare
For some reason the Intel Mac job keeps getting hung in CI. I'm going to see if I can determine if it's related to this PR or not before merging. |
The hang definitely appears to occur during |
I can reproduce the hang locally. Investigating. |
@hiddenalpha although I can reproduce the deadlock, I'm not sure why it's happening...
We may decide to just skip this test for MacOS, but before we make that decision, I'd like to know why. I can offer a Mac environment via SSH if needed. |
The hanging test on MacOS seems related to
and perhaps this and maybe this as well #53. |
Round 1: - Fix typo in exception msg. - Indent 'case' more. - use variable in place of constant. Round 2: - Ignore test on windoof. - Whops, did ignore the wrong test (force-pushed to fix the other one). Round 3: - Enable windoof test again as requested in PR review. Round 4: - Move failing OSX to its own test. Taken from 3dcb4ec.
661987e
to
98258e1
Compare
No description provided.