-
Notifications
You must be signed in to change notification settings - Fork 25
Modern I/O article (issue #26) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few suggestions.
These are just suggestions, I am just an outside user interested in this repo.
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found other minor things that may still be worth considering.
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your article and your changes to it. I think it turned out great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Cay. 👋🏾 Looks good but there are a few small fixes to make. I proposed many of them below.
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md
Outdated
Show resolved
Hide resolved
@cayhorstmann sorry for the delay, let's get this merged! What does everyone think about making this article the 5th in the I/O series [1]? |
I think it might be weird to have that article after Also, I just realized that the file here is just called |
I've already fixed the metadata locally. Just need a place to put the tutorial. We are leaning away from the series now. |
ok we're considering some possible content reorg strategies but for now I'm thinking keep it where it's at: "Mastering the API" section as its own article, not as part of the I/O series. |
ok metadata added, ready for merge here cc @cayhorstmann @ammbra @JosePaumard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- looking for one more review from Java team on organization
Should there be a table of contents? |
TOC should automatically build itself when missing |
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/01_modern_io.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/01_modern_io.md
Outdated
Show resolved
Hide resolved
boom thanks all! |
Thanks for finishing this, guys! 👍🏾 |
No description provided.