Skip to content

Introduction to Method Handles tutorial #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 2, 2024
Merged

Conversation

smthelusive
Copy link
Contributor

Method Handles article ready for review.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 1, 2024
Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some opinions on that article. I am an outside contributor and I don't have any authority over this repository.

I noticed quite a few lines ending with a single space. Is this deliberate?
When introducing methods (e.g. in the Lookup, MethodHandle or MethodHandles classes), it might be a good idea to link Javadocs.

Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nataliia,

I briefly left a few comments, but would also like to add the following general ones:

  • Please add links to JavaDoc for respective classes or methods.
  • Could you please add a bio similar to the one from JFall? 😄

@smthelusive
Copy link
Contributor Author

Hi @danthe1st and @ammbra, thank you both for the reviews.
I'll rework where I can or otherwise come back with questions 😃

@smthelusive
Copy link
Contributor Author

Hi @ammbra and @danthe1st,

I have pushed the changes with your comments addressed, could you please check?

Along with your suggestions I have also reordered some sections: the Method handles vs Reflection section mentions Method Handle transformations, so I thought it would be better to have the section about transformations before that. This way the readers already have some context about it.
Also, talking about reflection looks like a good thing to do at the end :)

Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes. I have commented on minor things I noticed while reading through your changes.

Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reading through your article again, I found a few things that could possibly be reworded.

@smthelusive
Copy link
Contributor Author

Thanks @danthe1st! I have pushed the changes.

Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this article and the changes you have made. For what I am concerned, this article looks good.

Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nataliia,

Thank you so much for updating the article. I left some small comments/suggestions, but overall is great work.

@carimura
Copy link
Member

We're close!! After these last comments are resolved I think we'll look to get this merged!

Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nataliia,

Thank you so much for your patience. I corrected some of typos and left one suggested. Would also like to request from you some changes for the conclusion (sorry for not catching this earlier).

@smthelusive
Copy link
Contributor Author

Hi @ammbra, thank you for the review and your help with fixes. I have made the changes, please let me know if it looks good or more adjustment required.

Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the article again and wrote down a few things I noticed.

@carimura
Copy link
Member

carimura commented May 29, 2024

Hi @smthelusive if you give me access to push commits I can go in and clean a few things up and help get this merged. I think we've gone back and forth long enough and I thank you for your patience and commitment to getting this over the line!

@smthelusive
Copy link
Contributor Author

Thank you for your help @carimura, I have sent you an invite. I'm still willing to fix whatever is missing, so feel free to leave anything on me, I will get to it as soon as I can.

@carimura
Copy link
Member

carimura commented May 30, 2024

OK I added a few grammar edits and reduced a few lines of code that felt repeated in the same section. Good from my end! I see @ammbra left a few comments that I think are still unresolved (I agree the conclusion could be a bit stronger) but other than that, we should be good to go! If you @smthelusive are busy this week (what remains of it :) ) we might be able to assist Friday and get things merged.

@smthelusive
Copy link
Contributor Author

Hi @carimura, I have resolved the leftover comments that I found.
The one from @ammbra about the conclusion I have fixed earlier but forgot to mark it as resolved.
Could you please advice on how I can improve the conclusion?

Also, thanks everyone for helping me out :)

Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

@ammbra ammbra merged commit ee5507f into java:main Jun 2, 2024
1 check passed
@carimura
Copy link
Member

carimura commented Jun 2, 2024

We're live! https://dev.java/learn/introduction_to_method_handles/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants