Rename codeclimate.json to gl-code-quality-report.json #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has lots of changes in code style. I suggest you to only change the necessary code. In parallel, maybe we should add a lint to force the style? Google java format for me is a good one: https://github.com/google/google-java-format If its a good thing to do I offer myself to create the issue and the PR. |
|
@lucasoares ah my bad. I had prettier configured for new projects in my ide. I'll fix the PR. |
Gitlab renamed this file in 11.0 and uses the new name in all code quality jobs. This will require people to update their jobs to the new name.
123Haynes
force-pushed
the
gl-code-quality-report
branch
from
a26cfd8 to
403b991
Compare
|
@lucasoares Now it should be good to go. Sorry about the mishap with the code formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab renamed this file in 11.0 and uses the new name in all code quality jobs.
We should do the same to avoid confusion when reading the different docs.
Warning: BREAKING CHANGE
This will require people to update their existing jobs to the new name.