-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced complexity for methods in JavaParserFacade
#3204
Reduced complexity for methods in JavaParserFacade
#3204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3204 +/- ##
===============================================
- Coverage 58.046% 57.397% -0.650%
+ Complexity 2621 2573 -48
===============================================
Files 628 616 -12
Lines 34224 34303 +79
Branches 5834 5800 -34
===============================================
- Hits 19866 19689 -177
- Misses 12322 12646 +324
+ Partials 2036 1968 -68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Apologies for the delay, but thank you @4everTheOne -- much appreciated 👍 Breaking it into the separate commits was really helpful 👍 Once the checks are complete it'll be merged in 🎉 |
JavaParserFacade
This PR refactors the JavaParserFacade code to make it easier to read. This also replaces the use of
instanceOf
with the correspondent "is" method (e.g. isClassOrInterfaceType() ) and the "as" method (eg. asClassOrInterfaceType() ).This was initially done in PR #3182 and was moved to this one to keep things separated.