Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3358 LexicalPreservingPrinter error on ArrayType #3359

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Fix issue 3358 LexicalPreservingPrinter error on ArrayType #3359

merged 2 commits into from
Aug 30, 2021

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Aug 30, 2021

Fixes #3358 .

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #3359 (94920f4) into master (1db3d41) will increase coverage by 0.007%.
The diff coverage is 81.818%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3359       +/-   ##
===============================================
+ Coverage     57.318%   57.325%   +0.006%     
  Complexity      2576      2576               
===============================================
  Files            620       620               
  Lines          34282     34297       +15     
  Branches        5804      5808        +4     
===============================================
+ Hits           19650     19661       +11     
  Misses         12668     12668               
- Partials        1964      1968        +4     
Flag Coverage Δ
AlsoSlowTests 57.325% <81.818%> (+0.006%) ⬆️
javaparser-core 52.981% <81.818%> (+0.011%) ⬆️
javaparser-symbol-solver 35.414% <0.000%> (-0.016%) ⬇️
jdk-10 57.318% <81.818%> (+0.007%) ⬆️
jdk-11 57.315% <81.818%> (+0.004%) ⬆️
jdk-12 57.318% <81.818%> (+0.007%) ⬆️
jdk-13 57.318% <81.818%> (+0.007%) ⬆️
jdk-14 57.318% <81.818%> (+0.007%) ⬆️
jdk-15 57.318% <81.818%> (+0.007%) ⬆️
jdk-16 57.315% <81.818%> (+0.004%) ⬆️
jdk-8 57.320% <81.818%> (+0.004%) ⬆️
jdk-9 57.315% <81.818%> (+0.007%) ⬆️
macos-latest 57.322% <81.818%> (+0.007%) ⬆️
ubuntu-latest 57.316% <81.818%> (+0.007%) ⬆️
windows-latest 57.322% <81.818%> (+0.007%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../printer/lexicalpreservation/ChildTextElement.java 56.000% <0.000%> (-2.334%) ⬇️
...arser/printer/lexicalpreservation/TextElement.java 66.666% <ø> (ø)
...parser/printer/lexicalpreservation/Difference.java 82.874% <85.000%> (-0.157%) ⬇️
.../printer/lexicalpreservation/TokenTextElement.java 90.000% <100.000%> (+0.344%) ⬆️
...src/main/java/com/github/javaparser/JavaToken.java 89.749% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341a25a...94920f4. Read the comment docs.

@jlerbsc jlerbsc merged commit 1cb84bd into javaparser:master Aug 30, 2021
@MysterAitch MysterAitch added the PR: Fixed A PR that offers a fix or correction label Sep 8, 2021
@MysterAitch MysterAitch added this to the next release milestone Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LexicalPreservingPrinter error on ArrayType
2 participants