Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring on LexicalreservingPrinter especially in the class Difference #3424

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Nov 27, 2021

No description provided.

@MysterAitch
Copy link
Member

MysterAitch commented Nov 27, 2021

Note there's currently an ongoing incident with Github Actions, which is likely why they're not running here.

Screenshot_20211127-230059_Chrome.jpg

@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Nov 28, 2021

@MysterAitch what can we do?

@MysterAitch
Copy link
Member

Looks like it's back up.

Maybe push it again +- a new commit to trigger checks again?

https://www.githubstatus.com/

Screenshot_20211128-094329_Chrome.jpg

@jlerbsc jlerbsc merged commit 9543d26 into javaparser:master Nov 28, 2021
@MysterAitch MysterAitch added this to the next release milestone Nov 28, 2021
@MysterAitch MysterAitch added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Nov 28, 2021
@MysterAitch MysterAitch changed the title Minor refactoring on LexicalreservingPrinter especially in the class Difference Minor refactoring on LexicalreservingPrinter especially in the class Difference Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants