Make resolution of implements and extends types start with the parent… #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… context of the class.
jlerbsc
reviewed
May 22, 2024
| @@ -465,17 +465,23 @@ private ResolvedReferenceType toReferenceType(ClassOrInterfaceType classOrInterf | |||
| // look for the qualified name (for example class of type Rectangle2D.Double) | |||
| className = classOrInterfaceType.getScope().get().toString() + "." + className; | |||
| } | |||
| SymbolReference<ResolvedTypeDeclaration> ref = solveType(className); | |||
|
|
|||
There was a problem hiding this comment.
Please comment on why, at this stage, type resolution should be delegated to the parent context.
There was a problem hiding this comment.
toReferenceType is used to resolve reference to "extends" and "implements" types. These types should not be resolved against e.g types with the same name defined within the class.
As per the test case I included --
class A extends B {
static class B ... {}
}
The B in "extends B" should not resolve to the B in "static class B"... Hence we should resolve based on the context containing the class.. Does this make sense?
There was a problem hiding this comment.
I meant adding comments to the code.
jlerbsc
changed the title
|
Thank you for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… context of the class.
Fixes #4427.