Skip to content

Clarification in the example of comma operator #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexandre887
Copy link
Member

Basic operators, maths

image

I think we need to add a clarification to this example, because if we run a = 1 + 2, 3 + 4 or (a = 1 + 2), 3 + 4 in strict mode, we get ReferenceError: a is not defined. I've seen several comments regarding this (some even tried to run this line of code with let: let a = 1 + 2, 3 + 4)

Copy link
Contributor

@shallow-beach shallow-beach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding an executable to this tricky caveat!

Please note that the comma operator has very low precedence, lower than `=`, so parentheses are important in the example above.

Without them: `a = 1 + 2, 3 + 4` evaluates `+` first, summing the numbers into `a = 3, 7`, then the assignment operator `=` assigns `a = 3`, and the rest is ignored. It's like `(a = 1 + 2), 3 + 4`.
Try running the following code (**we don't use `"use strict"` in the example below, otherwise we would get an error**):
Copy link
Contributor

@shallow-beach shallow-beach Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify to use strict:

Try running the following code:

```js run
let a;
a = 1 + 2, 3 + 4;
alert(a); // 3
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not totally sure why doesn't work with inline declaration tbh. let modifies operation order somehow i guess? could be part of explanation

```

An unusual result, isn't it? Especially considering that the `,` operator should “evaluate each expression, but return the result of only the last one”.
Copy link
Contributor

@shallow-beach shallow-beach Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little more direct:

This is confusing because the , operator should “evaluate each expression, but return the result of only the last one”.

```

An unusual result, isn't it? Especially considering that the `,` operator should “evaluate each expression, but return the result of only the last one”.

Without them: `a = 1 + 2, 3 + 4` evaluates `+` first, summing the numbers into `a = 3, 7`, then the assignment operator `=` assigns `a = 3`, and the rest is ignored. It's like `(a = 1 + 2), 3 + 4`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Without parentheses, a = 1 + 2, 3 + 4 evaluates + first, summing the numbers into a = 3, 7, then the assignment operator = assigns a = 3, and the rest (, 7) is ignored. It's like (a = 1 + 2), 3 + 4.

to emphasize the evaluation of 3+4?

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Aug 27, 2024
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Waiting for changes and /done from PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants