Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and Time #352

Merged
merged 30 commits into from
Aug 28, 2020
Merged

Conversation

Fedebornaz
Copy link
Contributor

Traducción del artículo Date and Time con sus respectivos ejercicios.

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2020

CLA assistant check
All committers have signed the CLA.

@maksumi
Copy link
Collaborator

maksumi commented Aug 19, 2020

Revisando

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lindo trabajo

Linea 97
agregaie ``` que falta (marca el final de un box), que no puedo agregar como suggest
ademass con eso los nros de linea van a coincidir

1-js/05-data-types/11-date/1-new-date/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/3-weekday/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Fedebornaz and others added 19 commits August 19, 2020 11:31
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz
Copy link
Contributor Author

/done

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me atreví a hacer unos commits así pasamos directamente a 2da revisión,
typos, "función", "desde" en una suggest mia, la s me falla (también sos revisor de mis revisiones, podes leerlas, cambiarlas, discutirlas) y

y , pido disculpas, volví atrás la sugerencia timestamp. Habia buscado mal la primera referencia, está perfectamente definida al principio. Así que saqué la re-definicipon desprolija que hice más adelante.

@maksumi
Copy link
Collaborator

maksumi commented Aug 19, 2020

Estaba revisando este artículo pero no podré cumplir con él a buena hora. Par no detenerlo más, pido la ayuda de @vplentinax, @EzequielCaste o algún otro reviewer que se tome la molestia de venir por aquí, leer el comentario y quiera echar una manita de gato con esto. Mil gracias de antemano

Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas, el resto correcto. Corregido esto, aprobamos.

1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/2-get-week-day/solution.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Fedebornaz and others added 4 commits August 27, 2020 22:26
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@Fedebornaz
Copy link
Contributor Author

Muchas gracias @vplentinax y @joaquinelio por tomarse el tiempo para hacer las reviews! Veo que la mayoría de las correcciones que me hicieron fueron typos, voy a investigar si hay alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

@Fedebornaz
Copy link
Contributor Author

/done

Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Según repo EN.
Según repo EN
@joaquinelio
Copy link
Member

alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

@Fedebornaz don maksumi recomendó
Spanish code spell checker
pero no lo probé... y sigo con los typos...

@joaquinelio joaquinelio merged commit c944cdf into javascript-tutorial:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants