Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Sent Events #381

Merged
merged 7 commits into from
Sep 21, 2020
Merged

Server Sent Events #381

merged 7 commits into from
Sep 21, 2020

Conversation

homero304
Copy link
Contributor

please review my PR

@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 17, 2020
Open
joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy claro, tá bueno
un par de cositas nomás

5-network/12-server-sent-events/article.md Outdated Show resolved Hide resolved
5-network/12-server-sent-events/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329 and others added 2 commits September 20, 2020 07:20
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
82d2366 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
72f9898 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

/done

joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry por la vuelta
una que sugerí me molesta,

y otra que molestaba no supe sugerir antes.

Molesta tambien lo de "cross origin", no traducirlo ni explicarlo,
pero linkea a FETCH en este mismo capitulo y es donde lo explica asi que es correcto que quede así.

5-network/12-server-sent-events/article.md Outdated Show resolved Hide resolved
5-network/12-server-sent-events/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax
vplentinax approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

omero329 and others added 2 commits September 20, 2020 15:26
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
cd290ad 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
aff46c4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

/done

@joaquinelio joaquinelio merged commit 7de52cc into javascript-tutorial:master Sep 21, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplentinax vplentinax vplentinax approved these changes

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@homero304 @javascript-translate-bot @joaquinelio @vplentinax @omero329