Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles and classes #413

Merged
merged 20 commits into from
Oct 20, 2020
Merged

Styles and classes #413

merged 20 commits into from
Oct 20, 2020

Conversation

dbritto-dev
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team October 8, 2020 17:47
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 8, 2020
Open
@dbritto-dev
Copy link
Contributor Author

@vplentinax el archivo de 2-ui/1-document/08-styles-and-classes/solution.md esta vacío

@vplentinax
Copy link
Contributor

vplentinax commented Oct 8, 2020 •
edited
Loading

@danilobrinu Comprueba si en la repo de inglés está vacío también. Si tiene contenido, tradúcelo tomando el contenido de allí.

@dbritto-dev
Copy link
Contributor Author

@vplentinax en el repo original también lo está.

repo original: https://github.com/javascript-tutorial/en.javascript.info/blob/master/2-ui/1-document/08-styles-and-classes/2-create-notification/solution.md

@vplentinax
Copy link
Contributor

Pues entonces no hay problema. No hay contenido. No se traduce nada.

@joaquinelio
Copy link
Member

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

@dbritto-dev
Copy link
Contributor Author

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

La verdad no te entendi nada jaja y no creo que tenga que ver con pensar como programador o no.

@joaquinelio
Copy link
Member

era solo una curiosidad, de por qué agregar solution vacio

@dbritto-dev dbritto-dev marked this pull request as ready for review October 17, 2020 18:34
joaquinelio
joaquinelio requested changes Oct 17, 2020
View reviewed changes
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-dev and others added 5 commits October 17, 2020 17:18
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
1910164 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
a6bce5b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
5bae251 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
68bfee0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
5516205 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-dev and others added 5 commits October 17, 2020 17:19
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
da858fa 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
d3f7554 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
4394f5b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
1409fae 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
b335cf5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 17, 2020 22:20
joaquinelio
joaquinelio requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se me escapó una.
Dos.
Creo que es todo.

2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
2-ui/1-document/08-styles-and-classes/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-dev and others added 2 commits October 18, 2020 08:31
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
0022411 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
e2cc988 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 18, 2020 13:31
vplentinax
vplentinax approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joaquinelio joaquinelio merged commit 9eb6aa8 into javascript-tutorial:master Oct 20, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

@vplentinax @danilobrinu

Me canse de hacer pr y me permiti hacer un commit directo, pero aviso.

task estaba traducida, faltaba una linea
"the options are" a "Las opciones son"
La solucion esta vacia porque solo funciona en nueva pagina o plnkr
y funciona nicely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplentinax vplentinax vplentinax approved these changes

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbritto-dev @vplentinax @joaquinelio @javascript-translate-bot