Skip to content

nullish-coalescing-operator finished #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 18, 2022

Conversation

ermogenes
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2020

CLA assistant check
All committers have signed the CLA.

@ermogenes ermogenes changed the title Tradução de nullish-coalescing-operator finalizada nullish-coalescing-operator finished Nov 18, 2020
@odsantos
Copy link
Contributor

Hi @ermogenes would you please resolve the conflicts, or inform if you're unavailable for this PR. Thank you.

@ermogenes
Copy link
Contributor Author

@odsantos conflicts resolved.

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ermogenes here is a files' check.
Please feel free to also comment if somewhere you disagree.
Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ermogenes and others added 3 commits December 28, 2020 08:00
Ajusta ortografia

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@ermogenes
Copy link
Contributor Author

/done

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ermogenes , the translation lines for the English line 44 and ahead seem not to match. Is it possible to delete the Portuguese extra blank lines (between line 43 and 47) to remove the discrepancy? Thank you.

@ermogenes
Copy link
Contributor Author

@odsantos Despite what GH shows in compare, I couldn't manage to locate the discrepancy. To me both files has the same line numbers and no extra breaks or spaces.

@odsantos
Copy link
Contributor

@ermogenes Thank you.

@odsantos
Copy link
Contributor

Hi @ermogenes,

This PR has one approval.
I wonder if it would be possible to keep it with no conflicts until another reviewer might approve it as well.
If you are not available to do it, would you please let me know to see if I might be able to do that?

Thank you,
Osvaldo.

@jonnathan-ls
Copy link
Contributor

Hi @ermogenes, alright?

Can you equalize the repositories, resolving existing conflicts?

If so, I will perform the analysis for the second review!

@ermogenes
Copy link
Contributor Author

@jonnathan-ls done

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermogenes My review! 😃

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ermogenes
Copy link
Contributor Author

/done

@jonnathan-ls jonnathan-ls merged commit 084f959 into javascript-tutorial:master Oct 18, 2022
@jonnathan-ls
Copy link
Contributor

Olá @ermogenes PR aceito, grato pela contribuição ❤️

Se conhecer outras pessoas interessadas em contribuir, sinta-se a vontade para convidá-las 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants