-
Notifications
You must be signed in to change notification settings - Fork 112
Sync with upstream @ fb4fc33a #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Few grammatical corrections
The sentence should say "Why we need tests" with no question mark, or "Why do we need tests?" I think keeping the question mark makes it more personal.
Potential Grammar Correction
it could be more intuitive. function() looks like calling a function but example is about function expression.
Fixed a small typo with pluralization.
store vs keeps stored
Plunker reminder #1775
Fix plural typo line 414
Fix comma splice.
pseudo function expression
Grammar Fix Update in article.md
Fix grammatical error
Few grammatical corrections
repeated word
FIX: minor typo error
FIX: The range of hexadecimal numbers is 0-9 or A-F
easier to read
"not required" vs "incorrect"
Update article.md
Remove mentions of :host-context
fix typo in 1-js/05-data-types/03-string
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve conflicts.
This PR was automatically generated to merge changes from en.javascript.info at fb4fc33
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
This PR will be closed and replaced with a new one in a few days.