Skip to content

Extending built-in classes #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2024
Merged

Extending built-in classes #413

merged 3 commits into from
Jan 13, 2024

Conversation

@danilolmc
Copy link
Contributor

@danilolmc danilolmc commented Jan 4, 2024

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 4, 2024 15:24
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 4, 2024

Error: the article already has PR number in the Progress Issue #1, it's 411 ⁉️

nazarepiedady
nazarepiedady reviewed Jan 7, 2024
View reviewed changes
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found two points to be reviewed, so I will pass to you @jonnathan-ls the responsibility of reviewing the rest.

@danilolmc danilolmc mentioned this pull request Jan 8, 2024
Closed
@danilolmc
Copy link
Contributor Author

danilolmc commented Jan 9, 2024

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team January 9, 2024 14:42
jonnathan-ls
jonnathan-ls approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me (LGTM)

@jonnathan-ls
Copy link
Contributor

jonnathan-ls commented Jan 13, 2024 •
edited
Loading

I just found two points to be reviewed, so I will pass to you @jonnathan-ls the responsibility of reviewing the rest.

Adicionei minha aprovação!

Por mais que ainda tenha solicitado alterações @nazarepiedady, acabou marcando a opção de review como comentário ... mas considerando que o @danilolmc já adicionou as alterações, entendo que a solicitação foi atendida, configurando como aprovada, então seguirei com o merge deste PR.

Quando adicionar uma revisão que tenha solicitações de mudança @nazarepiedady, procure marcar a opção:

Request changes
Submit feedback that must be addressed before merging.

Assim, o github registra as considerações e o BOT configurado do repositório consegue atuar, acho que foi por isso que ele acabou não atualizando o status deste PR, já que registrou como comentário em vez de request changes.

image

Obs.: Marcar como request changes e approved, mantém o vinculo de detalhes da aprovação associadas ao PR 01

@jonnathan-ls jonnathan-ls merged commit d43daf7 into javascript-tutorial:master Jan 13, 2024
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 13, 2024

Error: the article has another PR number in the Progress Issue #1, it's 411, not 413 ⁉️

@jonnathan-ls jonnathan-ls mentioned this pull request Jan 13, 2024
Open
@jonnathan-ls
Copy link
Contributor

jonnathan-ls commented Jan 13, 2024 •
edited
Loading

Error: the article has another PR number in the Progress Issue 1, it's 411, not 413 ⁉️

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady left review comments

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danilolmc @javascript-translate-bot @jonnathan-ls @nazarepiedady