listener pre-merge suggestions #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid checking selected_obj before it's available * Changelog * Added a test that fails on main
Remove incorrect changelog entry
…3111) * first pass at sb -> angle drop down changes * update conversion logic, .pix support for counts * update tests, cut out sb code * add comments, handle limits and choices * add change log * handle load_data case where PIXAR_SR not in metadata, reset limits adjustment * u.erg/u.s/u.cm**2/u.Angstrom in untranslatable units, switch from SB to flux for test * get_object -> get_component, 2 returns to 1 * broadcast sb_unit, fix zoom limits, ensure self.sb_unit sets * reconcile test failures * remove flux_or_sb extra conditions, small comment tweak * sb_unit -> sb_unit_selected for app._get_display_unit(sb) compatibility
* Add Gaia catalog to plugin Address review comments Add max rows option for Gaia * Update table with results * Address review comments * Update changes * Address review comments * Enable sources for SDSS * Remove using row limits for SDSS * Apply suggestions from code review Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
* Add jwebbinar videos and new mast video * typo * Update docs/video_tutorials.rst
…pacetelescope#3112) * expose surface brightness units in app._get_display_units
* Only show PIXAR_SR warning in cubeviz * More descriptive variable names * Fix codestyle
…cetelescope#3129) * get_data(use_display_units) to respect flux or sb selection * add to existing changelog entry * test coverage
* Replace wcs_use_affine with wcs_fast_approximation * Changelog and codestyle * Add deprecation warnings * Update concept notebooks * Use Astropy deprecation instead * Fix failing test * Make deprecation ignores explicit
upgrade upload-artifact to v4
remove magnitude units from display units list
…dant GlobalDisplayUnitChange broadcast (spacetelescope#3138) * observe display traitlets separately * . * remove redundant broadcast * code style
* Remove incorrect moveaxis call in spectrum1d_3d parser * Working on correcting expected test results * Continuing to work on tests * Update spectral extraction tests * Update aperphot test * Changelog * Make one cubeviz mouseover test sensitive to axis swap * Update comment * Update jdaviz/configs/cubeviz/plugins/tests/test_parsers.py
Remilestone 3133 to 4.0
because it is spamming the app
BUG: Remove spammy snackbar message
* data-menu UI improvements * API hints improved formatting * fix plt. api hint typos * custom API icons * improve dark-theme support --------- Co-authored-by: Jennifer Kotler <jkotler@stsci.edu>
* removing filter warning for mpl-scatter-density * replace deprecated pkg_resources call in linelists
…/github_actions/dot-github/workflows/actions-d260ee84de Bump the actions group in /.github/workflows with 2 updates
* subset plugin delay loading plugin results into viewers
Add WFI footprint to Footprints plugin
* expose user API for recenter_data and recenter * subset tools API hints * update tests
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
… tqdm use and import, and use main branch strauss which should now work for JDAViz!
github-actions
bot
added
embed
specviz
documentation
testing
cubeviz
imviz
mosviz
specviz2d
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sounddevicecase using empty class and setting a value forsd.default.device[1]- think this works in all casestqdm