AttributeError: 'TransitionApproval' object has no attribute 'iteration'

[xuziheng1002]

Program raise error as title when I try to jump state

Is this a bug? I think iteration is a field in Transition model, not TransitionApproval

source in river.core.instanceworkflowobject.py (line:91)

    @property
    def recent_approval(self):
        try:
            return getattr(self.workflow_object, self.field_name + "_transition_approvals").filter(transaction_date__isnull=False).latest('transaction_date')
        except TransitionApproval.DoesNotExist:
            return None

    @transaction.atomic
    def jump_to(self, state):
        def _transitions_before(iteration):
            return Transition.objects.filter(workflow=self.workflow, workflow_object=self.workflow_object, iteration__lte=iteration)

        try:
            recent_iteration = self.recent_approval.iteration if self.recent_approval else 0
            jumped_transition = getattr(self.workflow_object, self.field_name + "_transitions").filter(
                iteration__gte=recent_iteration, destination_state=state, status=PENDING
            ).earliest("iteration")

[xuziheng1002]

I think it should be self.recent_approval.transition.iteration (current: self.recent_approval.iteration)
is that right?

[javrasya]

Hi @xuziheng1002
At first glance, it seems to be. I would appreciate it if you can create PR with a test case for this. Otherwise, I can do it sometime this week.

[xuziheng1002]

Hi @xuziheng1002
At first glance, it seems to be. I would appreciate it if you can create PR with a test case for this. Otherwise, I can do it sometime this week.

OK, I will create PR with testCase this week.

[javrasya]

Hi @xuziheng1002
At first glance, it seems to be. I would appreciate it if you can create PR with a test case for this. Otherwise, I can do it sometime this week.

OK, I will create PR with testCase this week.

Here is where jumping to a specific state test case is. I don't know why it doesn't manage to catch this. But it is a good starting point to get some inspiration;

https://github.com/javrasya/django-river/blob/master/river/tests/core/test__instance_api.py#L1577

[xuziheng1002]

Hi @xuziheng1002
At first glance, it seems to be. I would appreciate it if you can create PR with a test case for this. Otherwise, I can do it sometime this week.

OK, I will create PR with testCase this week.

Here is where jumping to a specific state test case is. I don't know why it doesn't manage to catch this. But it is a good starting point to get some inspiration;

https://github.com/javrasya/django-river/blob/master/river/tests/core/test__instance_api.py#L1577

ok, is there any document that let me know how to initialize test db?
it seems should use the migration file in river.test.tmigration/* , isn't it?

[javrasya]

Unfortunately no documentation but if you want to run the tests with tox you don't need to do anything.
But if you want to run them through PyCharm, just run python manage.py migrate --run-syncdb before you run the tests.

[javrasya]

Your PR is merged to master. Thanks for that again ❤️
Do you need the new version released on PyPI immediately @xuziheng1002 ? Or can you use it from GitHub until it 3.1.4 is released? Otherwise, I can release a hotfix release today.

[xuziheng1002]

Fixed it in #139
Close