-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLM pretraining tutorial #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content overall! A few minor comments and then I'd love to get this merged 😁
Also re-ran the notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One last comment below.
After addressing that, could you please squash the changes into a single commit, and then we'll get this merged!
Might be easier if you choose 'Squash and merge' in the Merge dropdown menu?
|
Yeah I'll do that – sorry that response was force of habit: in the JAX repo it's not possible for the reviewer to squash commits. |
Please fix the lint errors – you can do this locally by running |
lint errors fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - let's get it in!
No description provided.