Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLM pretraining tutorial #81

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Add LLM pretraining tutorial #81

merged 6 commits into from
Nov 6, 2024

Conversation

windmaple
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content overall! A few minor comments and then I'd love to get this merged 😁

docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
docs/JAX_for_LLM_pretraining.md Show resolved Hide resolved
docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One last comment below.

After addressing that, could you please squash the changes into a single commit, and then we'll get this merged!

docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
@jakevdp jakevdp self-assigned this Nov 1, 2024
@jakevdp jakevdp added the documentation Improvements or additions to documentation label Nov 1, 2024
@windmaple
Copy link
Contributor Author

Might be easier if you choose 'Squash and merge' in the Merge dropdown menu?

Looks great! One last comment below.

After addressing that, could you please squash the changes into a single commit, and then we'll get this merged!

@jakevdp
Copy link
Collaborator

jakevdp commented Nov 4, 2024

Might be easier if you choose 'Squash and merge' in the Merge dropdown menu?

Yeah I'll do that – sorry that response was force of habit: in the JAX repo it's not possible for the reviewer to squash commits.

@jakevdp
Copy link
Collaborator

jakevdp commented Nov 4, 2024

Please fix the lint errors – you can do this locally by running pre-commit run jupytext --all-files and then committing the automatic changes.

@windmaple
Copy link
Contributor Author

lint errors fixed

docs/JAX_for_LLM_pretraining.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - let's get it in!

@jakevdp jakevdp merged commit 3cc817a into jax-ml:main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants