Added NLP: Basic text classification with JAX & Flax #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is timing out; it looks like you'll have to skip execution for this. |
vfdev-5
force-pushed
the
nlp-basic-text-classif
branch
from
2306623 to
b23e4e3
Compare
|
Looks really great – thanks for this! I'll wait on a review from @melissawm before merging. |
melissawm
reviewed
Nov 18, 2024
| print(f"- Accuracy: {eval_metrics_history['test_accuracy'][-1]:0.4f}") | ||
| ``` | ||
|
|
||
| Let us now start the training |
There was a problem hiding this comment.
Just a suggestion:
Suggested change
| Let us now start the training | |
| Now, we can start the training. Note that this step can take quite a while to run, depending on the number of epochs you are using. |
There was a problem hiding this comment.
Well, this is not exactly true, in this case, whole training takes 2 minutes. The model and the dataset are rather small.
There was a problem hiding this comment.
Interesting! For me it took something like 40 mins in colab.
vfdev-5
force-pushed
the
nlp-basic-text-classif
branch
from
b23e4e3 to
d6f9a40
Compare
vfdev-5
force-pushed
the
nlp-basic-text-classif
branch
3 times, most recently
from
61431a7 to
0549978
Compare
vfdev-5
force-pushed
the
nlp-basic-text-classif
branch
from
0549978 to
659a2fb
Compare
jakevdp
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @melissawm to review