Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom JVP rule for jnp.sinc #5054

Closed
jakevdp opened this issue Nov 30, 2020 · 0 comments · Fixed by #5077
Closed

Add custom JVP rule for jnp.sinc #5054

jakevdp opened this issue Nov 30, 2020 · 0 comments · Fixed by #5077
Assignees
Labels
bug Something isn't working

Comments

@jakevdp
Copy link
Collaborator

jakevdp commented Nov 30, 2020

The current implementation has incorrect even-ordered derivatives at x=0.0:

import matplotlib.pyplot as plt
import jax.numpy as jnp
from jax import grad, vmap

x = jnp.linspace(-5, 5, 101)
y = vmap(grad(grad(jnp.sinc)))(x)

plt.plot(x, y)

download

Related to #5039

@mattjj mattjj self-assigned this Dec 1, 2020
@mattjj mattjj added the bug Something isn't working label Dec 1, 2020
mattjj added a commit that referenced this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants