Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pjit's initial style usage of consts. #13893

Closed
wants to merge 0 commits into from
Closed

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 6, 2023

Fix pjit's initial style usage of consts.

Instead of smuggling them via the jaxpr, pull it out and pass them with args. This is because consts can be tracers and that fails down the stack when lowering to mlir.

Co-authored-by: Matthew Johnson mattjj@google.com

@copybara-service copybara-service bot force-pushed the test_499899435 branch 7 times, most recently from 575c43e to 53a0219 Compare January 7, 2023 03:09
@copybara-service copybara-service bot changed the title Fix pjit's initial style usage of consts Fix pjit's initial style usage of consts. Jan 7, 2023
@copybara-service copybara-service bot force-pushed the test_499899435 branch 2 times, most recently from b8cd366 to 8cc19f8 Compare January 7, 2023 03:13
@copybara-service copybara-service bot force-pushed the test_499899435 branch 6 times, most recently from c9c885a to beb53e4 Compare January 8, 2023 18:26
@copybara-service copybara-service bot closed this Jan 8, 2023
@copybara-service copybara-service bot deleted the test_499899435 branch January 8, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant