-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added How_JAX_primitives_work colab #1423
Conversation
@shoyer: Should this go into doc/notebooks or in notebooks/. I am not sure what criterion you use to decide this. |
This Colab can be viewed at https://colab.research.google.com/drive/16o1tffiB6QlGoDVScW9hYsJn2BsTVrpa |
There's no particular reason why we need to put notebooks in the "notebooks" subdirectory. I think the docs build will work fine with them anywhere inside the docs directory. One thing I do recommend is being careful with your use of top level ( |
Oh. I see now that you were asking about docs/notebooks vs notebooks :). I don't think there is any official policy, but my inclination would be to move over everything into the docs, whch I find to be much easier to navigate/browse. The only reason why I didn't do everything is that it takes a bit of tweaking to make notebooks look good after migrating, and I hadn't gotten around to it. |
What do I need to do to make sure that the Colab looks good (other than aligning the use of # with the other colabs)? |
You can run a docs build locally if you want to check it first... or we can just merge this (once we're happy with the content) and check/fix the formatting once it builds automatically after the merge. |
* Cleaned up use of section levels * Renamed ma to multiply_add and sq_add to square_add * Other minor clarifications * Separated the Colabs into Tutorials and Advanced Tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-Authored-By: James Bradbury <jekbradbury@google.com>
Co-Authored-By: James Bradbury <jekbradbury@google.com>
This addresses in part issue #116.