fix pow_p jvp rule at x=0. y=0 #16419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froystig
approved these changes
Jun 15, 2023
google-ml-butler
bot
added
kokoro:force-run
pull ready
mattjj
force-pushed
the
pow-jvp
branch
5 times, most recently
from
77f1610
to
e8dfc34
Compare
fixes jax-ml#14397 For autodiff purposes (and eventually for evaluation implementation purposes) we need to distinguish between pow :: inexact -> int -> inexact (which is differentiable at (0., 0)) and pow :: inexact -> inexact -> inexact (which isn't); see jax-ml#14397 (comment). Instead of making a new primitive, we made the old one polymorphic and switch its behavior on the element type of its second argument. There were also some other cases with special handling for algorithmic reasons (e.g. doing binary exponentiation), so these autodiff cases had to be merged with those algorithmic cases. Co-authored-by: Roy Frostig <frostig@google.com>
mattjj
added
pull ready
This was referenced Aug 25, 2023
mattjj
added a commit
to mattjj/jax
that referenced
this pull request
Oct 7, 2023
alhridoy
pushed a commit
to alhridoy/jax
that referenced
this pull request
Oct 20, 2023
alhridoy
pushed a commit
to alhridoy/jax
that referenced
this pull request
Oct 20, 2023
fixes jax-ml#17995 Add precision warning and workaround to jnp.arange documentation Remove mistakenly added file and update jnp.arange documentation Update jnp.arange documentation based on feedback CLA Issue Update arange documentation formatting as per review feedback Update arange documentation formatting as per review feedback Update lax_numpy.py merge conflict resolved fix pow jvp rule with int exponent (broken since jax-ml#16419) fixes jax-ml#17995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14397
For autodiff purposes (and eventually for evaluation implementation purposes) we need to distinguish between pow :: inexact -> int -> inexact (which is differentiable at (0., 0)) and pow :: inexact -> inexact -> inexact (which isn't); see #14397 (comment).
Instead of making a new primitive, we made the old one polymorphic and made it switch its behavior on the element type of its second argument.