simplify [p]xla.py by in-lining single-caller function #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions xla._compile_jaxpr and pxla.compile_replicated only had one caller each. The logic was confusing, and they had grown many arguments (and needed more!). By in-lining them we got a few other cleanups: - remove _parameter_or_create_token in favor of a common xla._xla_callable_args - fix a bug in the interaction between token inputs and arg tupling - finally plumb the user function name through to XLA metadata (!!)
|
Just noticed I forgot to add back a couple functions! Will do... EDIT: done! |
hawkinsp
reviewed
Nov 12, 2019
mattjj
added a commit
that referenced
this pull request
Nov 20, 2019
When #1667 inlined a function into its caller, it mixed up two distinct values referred to as `nrep` in the two functions: num_global_replicas vs num_local_replicas. The result caused errors on multi-host setups. Co-authored-by: Jonathan Heek <jheek@google.com>
mattjj
added a commit
that referenced
this pull request
Nov 20, 2019
When #1667 inlined a function into its caller, it mixed up two distinct values referred to as `nrep` in the two functions: num_global_replicas vs num_local_replicas. The result caused errors on multi-host setups. Co-authored-by: Jonathan Heek <jheek@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions xla._compile_jaxpr and pxla.compile_replicated only had one caller each. The logic was confusing, and they had grown many arguments (and needed more!).
By in-lining them we got a few other cleanups:
inner)FYI I got started on these cleanups because they make the lazy-sublanguage change I'm working on (#1668) easier to implement.