Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jnp.nonzero: deprecate zero-dimensional inputs #18850

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Dec 6, 2023

numpy.nonzero raises a DeprecationWarning in the same case, since numpy/numpy#13708

Also related to #18353, as the array API requires an exception in this case: https://data-apis.org/array-api/2022.12/API_specification/generated/array_api.nonzero.html

@jakevdp jakevdp self-assigned this Dec 6, 2023
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Dec 6, 2023
@copybara-service copybara-service bot merged commit 5bdc303 into jax-ml:main Dec 6, 2023
13 checks passed
@jakevdp jakevdp deleted the nonzero-zerodim branch December 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants