jnp.unique: make return_inverse shape match NumPy 2.0 #19320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
jakevdp
force-pushed
the
unique-inverse
branch
4 times, most recently
from
f8f1d36
to
141f753
Compare
pschuh
approved these changes
Jan 11, 2024
|
We need to hold-off on merging this, it looks like there's some second-guessing of the change now in the original NumPy PR. |
jakevdp
force-pushed
the
unique-inverse
branch
from
141f753
to
fa6d3f2
Compare
|
It seems the change is sticking upstream. Let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19246
Follows NumPy change in numpy/numpy#25553