Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jax.lax.tie_in #19413

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Deprecate jax.lax.tie_in #19413

merged 1 commit into from
Jan 19, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jan 18, 2024 •
edited
Loading

This is a pre-omnistaging relic that we should have removed a long time ago.

@jakevdp jakevdp self-assigned this Jan 18, 2024
@jakevdp jakevdp requested a review from froystig January 18, 2024 21:15
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Jan 18, 2024
@jakevdp jakevdp changed the title Deprecate jax.lax.tie_in Deprecate jax.lax.tie_in Jan 18, 2024
@copybara-service copybara-service bot merged commit 1f380e0 into jax-ml:main Jan 19, 2024
13 checks passed
@jakevdp jakevdp deleted the dep-tie-in branch January 19, 2024 03:26
@sharadmv
Copy link
Collaborator

🫡

copybara-service bot pushed a commit to google/flax that referenced this pull request Jan 19, 2024
Remove calls to deprecated function jax.lax.tie_in
3ca83a8 
This has been a no-op since jax v0.2.0, so it is safe to replace all occurances of the function with the second argument. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599920941
@copybara-service copybara-service bot mentioned this pull request Jan 19, 2024
Closed
copybara-service bot pushed a commit to google/flax that referenced this pull request Jan 19, 2024
Remove calls to deprecated function jax.lax.tie_in
e428438 
This has been a no-op since jax v0.2.0, so it is safe to replace all occurances of the function with the second argument. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599920941
@mattjj
Copy link
Collaborator

mattjj commented Jan 19, 2024

image

Context

(I'm so sorry, I can explain... it's shard_map tech debt.)

@sharadmv
Copy link
Collaborator

tie_in will live on forever: https://github.com/jax-ml/oryx/blob/28eaaccb31f057418bfda865793e9d25b77c0f5c/oryx/core/primitive.py#L263-L274

copybara-service bot pushed a commit to google-research/scenic that referenced this pull request Jan 19, 2024
Remove calls to deprecated function jax.lax.tie_in
d88f92d 
This has been a no-op since jax v0.2.0, so it is safe to replace all occurances of the function with the second argument. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599956347
@copybara-service copybara-service bot mentioned this pull request Jan 19, 2024
Merged
copybara-service bot pushed a commit to google-research/scenic that referenced this pull request Jan 19, 2024
Remove calls to deprecated function jax.lax.tie_in
6459d30 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599956347
copybara-service bot pushed a commit to google-research/scenic that referenced this pull request Jan 20, 2024
Remove calls to deprecated function jax.lax.tie_in
1858ace 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599956347
copybara-service bot pushed a commit to google-research/scenic that referenced this pull request Jan 20, 2024
Remove calls to deprecated function jax.lax.tie_in
2a9d79d 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 600117051
copybara-service bot pushed a commit to google/flax that referenced this pull request Jan 22, 2024
Remove calls to deprecated function jax.lax.tie_in
cec62fd 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 599920941
copybara-service bot pushed a commit to google/flax that referenced this pull request Jan 22, 2024
Remove calls to deprecated function jax.lax.tie_in
993aa2c 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 600515954
copybara-service bot pushed a commit to google-research/google-research that referenced this pull request Jan 25, 2024
@copybara-github
Remove calls to deprecated function jax.lax.tie_in
583d317 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 601530530
copybara-service bot pushed a commit to google/aqt that referenced this pull request Jan 29, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
5976a76 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602417629
@copybara-service copybara-service bot mentioned this pull request Jan 29, 2024
Open
copybara-service bot pushed a commit to google/trax that referenced this pull request Jan 29, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
b2286db 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602417629
@copybara-service copybara-service bot mentioned this pull request Jan 29, 2024
Open
copybara-service bot pushed a commit to google/trax that referenced this pull request Jan 29, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
05337a6 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602456018
@copybara-service copybara-service bot mentioned this pull request Jan 29, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 29, 2024
@tensorflower-gardener
Remove uses of deprecated jax.lax.tie_in
70f0aa3 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602487110
copybara-service bot pushed a commit to google/aqt that referenced this pull request Jan 30, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
d39c8f4 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602456055
@copybara-service copybara-service bot mentioned this pull request Jan 30, 2024
Merged
copybara-service bot pushed a commit to google/aqt that referenced this pull request Jan 30, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
214a451 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602456055
copybara-service bot pushed a commit to google/aqt that referenced this pull request Jan 30, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
6dcafcf 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602865274
copybara-service bot pushed a commit to google/trax that referenced this pull request Feb 1, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
cfde3a4 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 602456018
copybara-service bot pushed a commit to google/trax that referenced this pull request Feb 1, 2024
@copybara-github
Remove uses of deprecated jax.lax.tie_in
a6a508e 
This has been a no-op since jax v0.2.0, and passes the second argument through unchanged. `tie_in` will be deprecated as of jax v0.4.24; see jax-ml/jax#19413

PiperOrigin-RevId: 603220025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froystig froystig froystig approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakevdp @sharadmv @mattjj @froystig @kokoro-team