Workaround mpmath 1.3 bugs in tan and tanh evaluation at infinities. Restore log1p and arctanh success tests. #20688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR #10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d884454 by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from pearu:pearu/tan d884454 PiperOrigin-RevId: 623745127
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR openxla/xla#10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68200fe6a343c10b8e7129448dfc0d9aa57 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f69fb62a9d024cf5f9011ce30fdfd4dfa4 by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d88445489f525186800fb1c2a095bfca6b1de7bf by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10525 from pearu:pearu/tan d88445489f525186800fb1c2a095bfca6b1de7bf PiperOrigin-RevId: 623745127
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR #10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d884454 by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from pearu:pearu/tan d884454 PiperOrigin-RevId: 623745127
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR openxla/xla#10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68200fe6a343c10b8e7129448dfc0d9aa57 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f69fb62a9d024cf5f9011ce30fdfd4dfa4 by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d88445489f525186800fb1c2a095bfca6b1de7bf by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10525 from pearu:pearu/tan d88445489f525186800fb1c2a095bfca6b1de7bf PiperOrigin-RevId: 623745127
hawkinsp
approved these changes
Apr 11, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR #10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d884454 by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from pearu:pearu/tan d884454 PiperOrigin-RevId: 623807467
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 11, 2024
…l absolute values Imported from GitHub PR openxla/xla#10525 As in the title. Tan evaluation is verified against mpmath tan function. The corresponding unit tests are included in xla/tests/complex_unary_op_test.cc When jax-ml/jax#20688 lands, the follow-up PR will enable Tan tests at complex infinities. Copybara import of the project: -- 005ff68200fe6a343c10b8e7129448dfc0d9aa57 by Pearu Peterson <pearu.peterson@gmail.com>: Fix tan inaccuracies on complex inputs with large and small absolute values. -- ad3d31f69fb62a9d024cf5f9011ce30fdfd4dfa4 by Pearu Peterson <pearu.peterson@gmail.com>: Make generate_complex_unary_op_samples.py output clang-format stable -- d88445489f525186800fb1c2a095bfca6b1de7bf by Pearu Peterson <pearu.peterson@gmail.com>: Add unittests for Tan with complex inputs Merging this change closes #10525 PiperOrigin-RevId: 623807467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.
Also, restore log1p and arctanh success tests that were disabled in #20454 and #20560, respectively.
Required by openxla/xla#10525 to enable Tan unit-tests at complex infinities.