-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize array API in jax.numpy & deprecate jax.experimental.array_api #22818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
force-pushed
the
finalize-array-api
branch
6 times, most recently
from
August 1, 2024 17:50
2307caf
to
c347045
Compare
jakevdp
force-pushed
the
finalize-array-api
branch
from
August 1, 2024 18:16
c347045
to
e8dd609
Compare
vfdev-5
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
jakevdp
force-pushed
the
finalize-array-api
branch
from
August 1, 2024 18:19
e8dd609
to
14fa062
Compare
dfm
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very exciting - LGTM!
9 tasks
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
This target is no longer needed since the array_api module is now built-in to jax.numpy. Followup to #22818. PiperOrigin-RevId: 658518474
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
jax.numpy
supports the Python Array API Standard by default!Fixes #18353 and #21088
cc/ @vfdev-5 @Micky774