Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement np.linalg.multi_dot #2296

Closed
wants to merge 4 commits into from
Closed

Conversation

sudsj
Copy link

@sudsj sudsj commented Feb 23, 2020

Implements np.linalg.multi_dot, based on numpy's implementation
I will add tests, once I figure out how to write them.

  • Add tests

Related to #1999

@sudsj sudsj requested a review from shoyer February 23, 2020 19:55
@shoyer
Copy link
Collaborator

shoyer commented Feb 23, 2020

Please move the code that you copied/adapted from NumPy into jax/third_party/numpy/linalg.py, thanks!

@shoyer
Copy link
Collaborator

shoyer commented Feb 23, 2020

This also needs unit tests. See jax/tests/ for examples.

@hawkinsp
Copy link
Collaborator

It looks like #2726 finished off adding multi_dot. Thanks for the PR!

@hawkinsp hawkinsp closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants