GPU Pallas decode_attention
improvements
#24602
Merged
+243
−135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
start_idx
andkv_seq_len
to support fixed-sized cache decode and sliding window decode attentionq_heads // kv_heads > block_h
would cause out-of-bound indexingsm_scale
to1 / math.sqrt(q.shape[-1])
to matchjax.nn.dot_product_attention
default