[Mosaic GPU] Improve correctness of benchmarking scripts #24645
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
Oct 31, 2024
| @@ -378,7 +378,7 @@ def ref_f(x, y): | |||
| x, | |||
| y, | |||
| dimension_numbers=dimension_numbers, | |||
| preferred_element_type=jnp.float32, | |||
| preferred_element_type=out_dtype, | |||
There was a problem hiding this comment.
I think I originally did it to prevent having the baseline use f16 accumulators for 16-bit inputs. Is there some way to enforce that we use 32-bit accumulation in this dot?
apaszke
approved these changes
Nov 7, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the reference function for matmul,
preferred_element_type=jnp.float32in combination withastype(out_dtype)was forcing a conversion from fp32 down to fp16, causing an additional kernel to run.