Canonicalize platform name for compile-only backends #25033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yashk2810 This is just a draft PR to ask around if this approach makes sense before I go into writing a test. Does the approach make sense to you? |
jaro-sevcik
force-pushed
the
compile-only-platform-canonicalization
branch
from
9893da3
to
d275c58
Compare
jaro-sevcik
force-pushed
the
compile-only-platform-canonicalization
branch
from
683f9da
to
fe6d5e2
Compare
jaro-sevcik
force-pushed
the
compile-only-platform-canonicalization
branch
from
fe6d5e2
to
ea681c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, platform name canonicalization triggers only for platforms that have runtime backends.
As a result, deviceless ahead-of-time compilation fails because there is no runtime backend without a device (and platform name canonicalization is required by MLIR lowering).
This patch registers compile-only backends (with their canonical names) in xla_bridge when the backends are created and then uses the canonical name when we try to extract the platform name from a backend. With this patch, topology-based AOT works even when there is no device for the platform.
Fixes #23971.