Fixes incorrect sharding lowering for key<fry> in shard_map partial-auto #25692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yliu120
force-pushed
the
rng_key_sharding
branch
from
25b9c6f to
fa7d807
Compare
yliu120
force-pushed
the
rng_key_sharding
branch
from
fa7d807 to
97b1faa
Compare
|
@mattjj Here is another bug. Please take a look. Thanks. |
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended type
key<fry>needs to be expanded to u32[2] before being used in manual_proto, otherwise the ranks in the sharding is not correct.