Update :build_jaxlib flag to control whether we should add py_import dependencies to the test targets.
#26945
+384
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_733777754
branch
4 times, most recently
from
793b9fe to
394a337
Compare
copybara-service
bot
changed the title
pypi wheel dependencies with py_import.:py_import flag that controls whether we should add py_import dependencies to the test targets.
copybara-service
bot
force-pushed
the
test_733777754
branch
from
394a337 to
03b29a8
Compare
copybara-service
bot
changed the title
:py_import flag that controls whether we should add py_import dependencies to the test targets.:build_jaxlib flag to control whether we should add py_import dependencies to the test targets.
copybara-service
bot
force-pushed
the
test_733777754
branch
4 times, most recently
from
6722ec0 to
aa403e2
Compare
…rt` dependencies to the test targets. This change enables testing the wheels produced by the build rules in the presubmit using one `bazel test` command only. There are three options for running the tests: 1) `build_jaxlib=true`: the tests depend on JAX targets. 2) `build_jaxlib=false`: the tests depend on the wheel files located in the `dist` folder. 3) `build_jaxlib=wheel`: the tests depend on the py_import targets. PiperOrigin-RevId: 735765819
copybara-service
bot
force-pushed
the
test_733777754
branch
from
aa403e2 to
1aca76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
:build_jaxlibflag to control whether we should addpy_importdependencies to the test targets.This change enables testing the wheels produced by the build rules in the presubmit using one
bazel testcommand only.There are three options for running the tests:
build_jaxlib=true: the tests depend on JAX targets.build_jaxlib=false: the tests depend on the wheel files located in thedistfolder.build_jaxlib=wheel: the tests depend on the py_import targets.