Fix a bug where full and use_mesh outside jit did not work because the shard passed to make_array_from_callback was sharded on all devices instead of just 1 device.
#27076
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_735894275
branch
3 times, most recently
from
ecf5a02 to
06a4bee
Compare
…e the `shard` passed to `make_array_from_callback` was sharded on all devices instead of just 1 device. This is because `convert_element_type` returning an output on all devices of the mesh because of the surrounding `use_mesh` context. PiperOrigin-RevId: 735909962
copybara-service
bot
force-pushed
the
test_735894275
branch
from
06a4bee to
f45cbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where
fullanduse_meshoutside jit did not work because theshardpassed tomake_array_from_callbackwas sharded on all devices instead of just 1 device.This is because
convert_element_typereturning an output on all devices of the mesh because of the surroundinguse_meshcontext.