Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top_k jvp and batching rules and tests #2853

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add top_k jvp and batching rules and tests #2853

merged 1 commit into from
Apr 28, 2020

Conversation

levskaya
Copy link
Collaborator

No description provided.

@hawkinsp
Copy link
Collaborator

Can you add top_k to the lax docs also? It sounds like we are declaring this "supported" more or less.

mattjj
mattjj approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@mattjj mattjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, expertly done as always. One idea offered, but LGTM!

hawkinsp
hawkinsp reviewed Apr 28, 2020
View reviewed changes
@levskaya levskaya merged commit ca4e396 into jax-ml:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkinsp hawkinsp hawkinsp left review comments

@mattjj mattjj mattjj approved these changes

@jekbradbury jekbradbury jekbradbury left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@levskaya @hawkinsp @mattjj @jekbradbury @googlebot