Add a cache around abstract_eval rules. #29498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_771059608
branch
2 times, most recently
from
92e23df to
24e9026
Compare
PiperOrigin-RevId: 772952508
copybara-service
bot
force-pushed
the
test_771059608
branch
from
24e9026 to
9cf81e4
Compare
rniczh
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Nov 28, 2025
**Context:** **Description of the Change:** - The API of `lower_jaxpr_to_fun` has changed, replacing `public` with `main_function`. Now, custom function names (e.g., `jit_…`) were not permitted, with `main` being the default. To address this, `main_function` is now set to False, while `sym_visibility` is set to True for MLIR, retaining the `jit_func` function name. Additionally, `name_stack` has been removed. jax-ml/jax#29783 - Params are now required to be hashable. (PL) jax-ml/jax#29498 - `make_var` and `get_var` has been removed. Should set the var (`val`) when initializing the `DynamicJaxprTracer`. jax-ml/jax#29937. There is a typo in jax jax-ml/jax#32718, we will patch the installation of jax in this PR. - Replace `flatten_lowering_ir_args` with `flatten_ir_values` jax-ml/jax#29706 - jax introduced the `TracingEqn` and replace `frame.eqns` (originally using `JaxprEqn`) with `frame.tracing_eqns`. jax-ml/jax#30135 - `pjit_p` has been removed, use `jit_p` instead - Fix jax source code by patching it when after jax is installed (run `bin/patch_jax_installation.py`) - Fix jax source code by patching it with (`frontend/catalyst/jax_extras/patches.py`) **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: JerryChen97 <chenys13@outlook.com> Co-authored-by: Paul <79805239+paul0403@users.noreply.github.com> Co-authored-by: David Ittah <dime10@users.noreply.github.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cache around abstract_eval rules.