refactor call primitives, simpler param processing #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekbradbury
reviewed
Jun 21, 2020
mattjj
added a commit
that referenced
this pull request
Jun 23, 2020
mattjj
added a commit
that referenced
this pull request
Jun 23, 2020
copybara-service bot
pushed a commit
to google-deepmind/dm-haiku
that referenced
this pull request
Jun 24, 2020
PiperOrigin-RevId: 317995257 Change-Id: Iaaf74b9c1517a7e781e654cfd28afa358c6350b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically #2829 again, though also with a refactoring of how params to call primitives are handled (like
donated_invars).I split these changes out of #3370 to try to shrink that PR down a bit.
There was one strange bug that arose with
check_jaxprandinvertible_callwhich doesn't appear in #3370. It's subtle enough that because it'll go away after #3370 I didn't fix it here and instead just skip a check incheck_jaxprforinvertible_calleqns.EDIT see #3530 for the fix