Cleanup: fix type issues in lax_numpy.py #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are basically a no-op wth the current default types, but fixes issues if/when those types are changed to 32-bit in the future.
hawkinsp
approved these changes
Jul 22, 2020
| @@ -204,6 +204,13 @@ def _make_scalar_type(np_scalar_type): | |||
|
|
|||
| _canonicalize_axis = lax._canonicalize_axis | |||
|
|
|||
| _DEFAULT_TYPEMAP = { | |||
There was a problem hiding this comment.
This change looks unrelated, or at least, I can't see why it would change anything?
There was a problem hiding this comment.
Yeah - I moved this to a global constant because initially I used it in arange as well, before landing on the current approach. I thought it made more sense as a global constant, so I left it.
NeilGirdhar
pushed a commit
to NeilGirdhar/jax
that referenced
this pull request
Jul 24, 2020
These changes are basically a no-op wth the current default types, but fixes issues if/when those types are changed to 32-bit in the future.
NeilGirdhar
pushed a commit
to NeilGirdhar/jax
that referenced
this pull request
Jul 24, 2020
These changes are basically a no-op wth the current default types, but fixes issues if/when those types are changed to 32-bit in the future.
NeilGirdhar
pushed a commit
to NeilGirdhar/jax
that referenced
this pull request
Jul 24, 2020
These changes are basically a no-op wth the current default types, but fixes issues if/when those types are changed to 32-bit in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are basically a no-op wth the current default types, but fixes issues if/when those types are changed to 32-bit in the future.