Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note on autodiff of OOB indexing #5813

Merged
merged 2 commits into from
May 21, 2021
Merged

add note on autodiff of OOB indexing #5813

merged 2 commits into from
May 21, 2021

Conversation

jekbradbury
Copy link
Contributor

Doc note suggested in #5760

@jekbradbury jekbradbury requested a review from shoyer February 23, 2021 11:22
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@jekbradbury
Copy link
Contributor Author

Oops, looks like I need to check out and run the pre-commit workflow locally. @jakevdp I'm guessing there's no way to make jupytext run automatically on docs PRs created from the web interface?

@8bitmp3
Copy link
Contributor

8bitmp3 commented May 21, 2021

Just noticed that this PR - for the 🔪 Common Gotchas 🔪 notebook - can't pass the jupytext lint test, so it's been sitting there kind of idle 🤷‍♂️

@jakevdp
Copy link
Collaborator

jakevdp commented May 21, 2021

I synced the notebook; we should be able to merge this now.

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label May 21, 2021
@copybara-service copybara-service bot merged commit 56e9f7c into master May 21, 2021
@8bitmp3
Copy link
Contributor

8bitmp3 commented May 21, 2021

cool, thanks @jakevdp @jekbradbury

@jakevdp jakevdp deleted the ad-oob-docs branch May 21, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants