Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: add NonConcreteBooleanIndexError & debugging tips #6186

Merged
merged 1 commit into from
Mar 23, 2021
Merged

errors: add NonConcreteBooleanIndexError & debugging tips #6186

merged 1 commit into from
Mar 23, 2021
+130 −14

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Mar 23, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@jakevdp jakevdp added the better_errors Improve the error reporting label Mar 23, 2021
@jakevdp jakevdp requested a review from froystig March 23, 2021 18:41
@jakevdp jakevdp mentioned this pull request Mar 23, 2021
Closed
froystig
froystig approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@froystig froystig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Mar 23, 2021
@copybara-service copybara-service bot merged commit 22a2be3 into jax-ml:master Mar 23, 2021
@jakevdp jakevdp deleted the bool-index-err branch March 23, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froystig froystig froystig approved these changes

Assignees
No one assigned
Labels
better_errors Improve the error reporting cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakevdp @froystig