enable fori-to-scan lowering #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @mattjj! The docstring needs to updated to mention the lowering to scan. |
mattjj
force-pushed
the
lower-fori-to-scan-2
branch
from
1f4ddb9 to
4ac8937
Compare
jekbradbury
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
lax.fori_loophas static bounds, we can lower it to ascanand thus support efficient reverse-mode autodiff.We had attempted to add this in #2414, but had to disable it for some weird
custom_transformsreason. That means #2026 unblocked it (and maybe #3370 helped too)!.