cache initial-style jaxpr transformations #9196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froystig
approved these changes
Jan 14, 2022
mattjj
added a commit
to mattjj/jax
that referenced
this pull request
Jan 18, 2022
follow-up to jax-ml#9196
|
This was merged, but not marked as merged... |
This was referenced Mar 4, 2022
mattjj
added a commit
to mattjj/jax
that referenced
this pull request
Mar 7, 2022
In jax-ml#9196 I missed a related utilty function which needed memoization.
mattjj
added a commit
to mattjj/jax
that referenced
this pull request
Mar 7, 2022
In jax-ml#9196 I missed a related utilty function which needed memoization. Co-authored-by: Adam Paszke <apaszke@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduce the tracing time on the shoyer version of the code in #3847 from ~50s to ~2.5s.
I'm a little wary to add more caching until we land #9188 to fix #9187.But otherwise this is straightforward!I think we can say this fixes #3847, though there's a lot more improvement we could make in this area.