Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm #65

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix arm #65

merged 2 commits into from
Aug 24, 2023

Conversation

jwhitaker-swiftnav
Copy link
Contributor

@jwhitaker-swiftnav jwhitaker-swiftnav commented Aug 17, 2023

I think this should fix #61 :)

It's a bummer that github hosted runners don't offer arm.. :(

this works on an internal company project against golang-migrate though.

@jwhitaker-swiftnav
Copy link
Contributor Author

ping @jaxxstorm

@jaxxstorm
Copy link
Owner

Is there any context on why this fixes arm builds? I'm happy to merge, but without a test or info about why this works I'm a little reluctant

@jwhitaker-swiftnav
Copy link
Contributor Author

Ah sure, sorry - the return is a bug, it should be a break. The function still has a lot to do after switch statement here, so returning early skips all that remaining work that is needed.
This should be clearly visible viewing the function as a whole, but github's diff view of a few lines doesn't really give enough context to see that.
Cheers!

@jaxxstorm jaxxstorm merged commit 2fba7e5 into jaxxstorm:master Aug 24, 2023
35 checks passed
renovate bot added a commit to mykso/myks that referenced this pull request Feb 10, 2024
…11.0 (#239)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[jaxxstorm/action-install-gh-release](https://togithub.com/jaxxstorm/action-install-gh-release)
| action | minor | `v1.10.0` -> `v1.11.0` |

---

### Release Notes

<details>
<summary>jaxxstorm/action-install-gh-release
(jaxxstorm/action-install-gh-release)</summary>

###
[`v1.11.0`](https://togithub.com/jaxxstorm/action-install-gh-release/releases/tag/v1.11.0)

[Compare
Source](https://togithub.com/jaxxstorm/action-install-gh-release/compare/v1.10.0...v1.11.0)

##### What's Changed

- Configure Renovate by
[@&#8203;renovate](https://togithub.com/renovate) in
[jaxxstorm/action-install-gh-release#30
- Ensure that binaries-location is used when caching is enabled by
[@&#8203;DavidGregory084](https://togithub.com/DavidGregory084) in
[jaxxstorm/action-install-gh-release#50
- remove opentelemetry latest by
[@&#8203;jaxxstorm](https://togithub.com/jaxxstorm) in
[jaxxstorm/action-install-gh-release#59
- Fix arm by
[@&#8203;jwhitaker-swiftnav](https://togithub.com/jwhitaker-swiftnav) in
[jaxxstorm/action-install-gh-release#65
- fixing tfsec arch by
[@&#8203;jaxxstorm](https://togithub.com/jaxxstorm) in
[jaxxstorm/action-install-gh-release#73
- add promtool by [@&#8203;jaxxstorm](https://togithub.com/jaxxstorm) in
[jaxxstorm/action-install-gh-release#74
- Handle 'EXDEV: cross-device link not permitted' by
[@&#8203;elventear](https://togithub.com/elventear) in
[jaxxstorm/action-install-gh-release#76
- Update dependency
[@&#8203;types/node](https://togithub.com/types/node) to v20 by
[@&#8203;renovate](https://togithub.com/renovate) in
[jaxxstorm/action-install-gh-release#70
- upgrades run-as node version by
[@&#8203;codevbus](https://togithub.com/codevbus) in
[jaxxstorm/action-install-gh-release#79

##### New Contributors

- [@&#8203;renovate](https://togithub.com/renovate) made their first
contribution in
[jaxxstorm/action-install-gh-release#30
- [@&#8203;DavidGregory084](https://togithub.com/DavidGregory084) made
their first contribution in
[jaxxstorm/action-install-gh-release#50
- [@&#8203;jwhitaker-swiftnav](https://togithub.com/jwhitaker-swiftnav)
made their first contribution in
[jaxxstorm/action-install-gh-release#65
- [@&#8203;elventear](https://togithub.com/elventear) made their first
contribution in
[jaxxstorm/action-install-gh-release#76
- [@&#8203;codevbus](https://togithub.com/codevbus) made their first
contribution in
[jaxxstorm/action-install-gh-release#79

**Full Changelog**:
jaxxstorm/action-install-gh-release@v1...v1.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/mykso/myks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-detection of ARM runner fails
2 participants